Add is.valid(DT) function

Open
#2,334 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

  • #4480 by @jangorecki — closed without merging

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start by reading PR #2332 and the linked PR #4480 to understand the existing key and index validity checks. The payload names no files or tests; done means defining and implementing is.valid(DT) so it checks key ordering and index ordering, including cases where those attributes were changed directly.

Written by the indexing model from the issue text.

Description

feature request

Excellent PR #2332 (which removed the repeated and wasteful check that current keys are valid) triggered the thought that perhaps we need an is.valid(DT) function for use by users. It would check that DT is indeed sorted by the key (if any) and that the indexes (if any) do indeed sort those index columns correctly. Although unlikely, it is possible for advanced users to go 'under the hood' and change attributes directly and that's when mistakes can happen. They can decide to use is.valid(DT) to check all is well at a moment that suits them.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.