consolidate code for reading data from file

Open
#2,261 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start by inspecting the four data-reading locations identified in sections [7], [8], [9], and [12], including separator and quote detection, column-name detection, sampling and type detection, and actual file reading. Consolidate them around one common procedure, with all four stages using it and the existing data-reading behavior preserved.

Written by the indexing model from the issue text.

Description

fread internals refactor

Currently there are 4 different places where the data is being read:

  • section [7], detection of the separator and quote rule
  • section [8], detection of column names
  • section [9], file sampling and detection of column types
  • section [12], actual file reading

It would be great if they all could use the same common procedure, which would make it easier to introduce other improvements into the code.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.