Extend ..var to work in some other cases

Open
#2,057 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

The issue gives f2 and f3 as the target cases; start by reproducing both in data.table and tracing the existing ..var lookup rules. Define which syntax should be supported, then verify the selected behavior for both equality filtering and on=.(v) joins.

Written by the indexing model from the issue text.

Description

programming

I have a column named v and want to filter my table by equality testing that column against a particular value, which I also call v (passing it via a function):

library(data.table)
L = list(A = list(B = list(CDT = data.table(v = c("bah", "egad")))))

# my current function
f = function(v){
  v0 = v
  myCDT = L$A$B$CDT[v == v0]
  # ... do other stuff ...
}

f("bah")[]
#      v
# 1: bah

I'd like to retain my preferred naming pattern without fiddling with the assignment to v0:

# what I'd like to write
f2 = function(v){
  myCDT = L$A$B$CDT[.(..v), on=.(v)]
  # ...
}
# or
f3 = function(v){
  myCDT = L$A$B$CDT[v == ..v]
  # ...
}

Neither of these works right now because ..var is only checked when j matches it (is my understanding),. But it would be nice to have... that or some other simple way of disambiguating in cases like this.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.