further data.frame-like consistency in j: logical vector
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 42/100
Research direction
Start by reading the comparison with data.frame and the related issue #1188, then locate the data.table subsetting implementation and its tests for logical column vectors. Reproduce the sapply(DF, is.numeric) examples before changing anything. Done means the data.table result is consistent with the data.frame result, with regression coverage for this case.
Written by the indexing model from the issue text.
Description
This is simply an extension of #1188 asking for data.frame-like consistency with respect to another common subsetting operation:
set.seed(2030)
DF = data.frame(a = LETTERS, b = letters, c = rnorm(26), d = rnorm(26), e = as.factor(1:26))
DF[ , sapply(DF, is.numeric)]
# c d
# 1 1.22587150 0.654058019
# 2 -1.02641266 1.442031659
# 3 -1.33873014 -0.442854108
# --TRUNCATED --
# 24 0.73060958 0.513225722
# 25 0.33502260 0.543853894
# 26 0.53034743 -1.786070335
setDT(DF)
DF[ , sapply(DF, is.numeric)]
# a b c d e
# FALSE FALSE TRUE TRUE FALSE
For now, the workaround is to wrap sapply in which. But here is another case where the data.frame code is more readable and I think unambiguous.
- Dominant language
- R
- Stars
- 3.9k
- Forks
- 1.1k
- Avg merge
- 14h 4m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Rdatatable/data.table
-
as.data.table() recurses without end on a survival::Surv object (or any data.frame carrying one) Open
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Rdatatable/data.table#7887 ·
-
consistency tests
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#7853 · 3 comments ·
-
internals
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#6938 · 1 comment ·
-
encoding fread
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rdatatable/data.table#5179 · 8 comments ·
-
documentation programming
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Rdatatable/data.table#3199 · 3 comments ·
All issues in Rdatatable/data.table
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
r-lib/pkgdepends#485 · 3 comments ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
beginners blocker
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enviPathR OpenBuild Error Build OK Build Warning policies-accepted pre-review precheck-passed
Difficulty 1/5 Under an hour Newbie friendliness 84/100
Bioconductor/BiocContributions#207 · 6 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
datacarpentry/semester-biology#1255 ·