Auto indexing should be skipped if subset and modify are on the same column

Open
#1,264 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
r
Domain
data

Research direction

Start by reproducing the provided data.table expression and inspect when the index is created and then removed. Done means the subset-and-modify operation does not create an unnecessary index on the modified column, while the existing indexing behavior remains unchanged for other operations.

Written by the indexing model from the issue text.

Description

enhancement

See this SO post for more info. Doing:

DT[y %in% 5:10, y := 100]

will create an index, and get modified, which results in the index getting removed, and as a result will be slow (due to creating the index unnecessarily every time) on bigger data.

Dominant language
R
Stars
3.9k
Forks
1.1k
Avg merge
14h 4m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Rdatatable/data.table

All issues in Rdatatable/data.table

Similar issues

More R issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.