tbb.h deprecated features

Open
#191 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
backend

Research direction

Start with inst/include/RcppParallel/TBB.h at the tbb/tbb.h include, then review how that header is reached through RcppParallel.h and the reported fittingFunctions.cpp compilation. Consult the TBB reference manual's Deprecated Features appendix and determine a migration path that removes the deprecation warning while preserving package compilation.

Written by the indexing model from the issue text.

Description

Packages compiling against RcppParallel show:

In file included from /usr/local/lib/R/library/RcppParallel/include/RcppParallel/TBB.h:10,
                 from /usr/local/lib/R/library/RcppParallel/include/RcppParallel.h:21,
                 from fittingFunctions.cpp:6:
/usr/include/tbb/tbb.h:21:154: note: '#pragma message: TBB Warning: tbb.h contains deprecated functionality. For details, please see Deprecated Features appendix in the TBB reference manual.'
   21 | #pragma message("TBB Warning: tbb.h contains deprecated functionality. For details, please see Deprecated Features appendix in the TBB reference manual.")
      |                                                                                                                                                          ^

tbb/tbb.h is included here. We should think about moving away from that header.

Dominant language
C++
Stars
173
Forks
60
Avg merge
1h 55m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RcppCore/RcppParallel

All issues in RcppCore/RcppParallel

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.