R 3.6.x Update for Sample Extension

Open
#250 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp, r
Domain
tooling

Research direction

Start by reading inst/include/RcppArmadillo/Alt_R_RNG.h and the sample extension at inst/include/RcppArmadilloExtensions/sample.h. Compare their RNG handling with the linked Base R commits covering rejection sampling, R_unif_rand(), and Walker sampling. Done means the sample extension follows the required R 3.6.x behavior, including the mentioned Rcpp local variant.

Written by the indexing model from the issue text.

Description

enhancement help wanted

Glancing over the RcppArmadillo code, the Alt RNG setup directly uses R's RNG for uniform (e.g. Rf_runif(). However, the extension code in inst/RcppArmadilloExtension/sample.h does not.

So, likely this will need a patch that mirrors what is available in Base R. c.f. Implementation changes.

This will likely be needed with Rcpp's local variant as well designed by @nathan-russell.

Dominant language
C++
Stars
211
Forks
54
Avg merge
5m
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from RcppCore/RcppArmadillo

All issues in RcppCore/RcppArmadillo

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.