params command in driver is slow for large models

Open
#2,651 0 comments 0 reactions 1 assignee View on GitHub

@kahmed10 is already working on this.

Since Jan 17, 2024.

Assessment

This issue has not been assessed yet.

Description

The following command ./drive params [model.onnx] can be very slow on large models. This is because we construct the entire graph before fetching the params. This also causes an unintended bug if the input params need their correct shape passed in to the command line before performing a driver read. So you may get an exception thrown when all you wanted to see were the params.

2 options to solve this:

  1. modify onnx parser to retrieve input params only
  2. have user refer to a new helper script that can fetch input params from onnx files
Dominant language
C++
Stars
333
Forks
150
Avg merge
4d 19h
Merged PRs (30d)
54

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ROCm/AMDMIGraphX

All issues in ROCm/AMDMIGraphX

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.