QuantEcon / QuantEcon/lecture-python-programming

environment.yml uses conda channel 'default' instead of 'defaults'; trailing space in _toc.yml

未关闭 适合新手
#607 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

主要语言
JavaScript
星标
72
派生
31
平均合并
2 天 20 小时
30 天内合并 PR
8

描述

Two small defects in the build configuration, both found while porting this repo's scaffold into the new lecture-python-programming.ml edition (QuantEcon/lecture-python-programming.ml#6). Neither breaks the build today; the first is a latent failure worth getting ahead of.

1. environment.yml names the conda channel default, not defaults

default is not a conda channel. Conda adds it as a literal channel name and then resolves the packages from defaults, which it still adds implicitly — and warns about doing so:

Adding channel 'default'
[command]/home/runner/miniconda3/condabin/conda config --add channels default
##[warning]The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'.

So the environment resolves by accident. Conda is deprecating the implicit-defaults behaviour, and when it goes the build fails to resolve anything.

This affects three editions — this repo, lecture-python-programming.fr and lecture-python-programming.fa — all of which carry - default. lecture-python-programming.zh-cn already has - defaults and is unaffected, so the corrected form is already proven in the fleet.

The fix is one word in environment.yml.

2. lectures/_toc.yml line 39 has a trailing space

The entry reads - file: workspace rather than - file: workspace. This is harmless in practice — YAML strips trailing whitespace from plain scalars, so both jb build and any tooling reading the file see workspace — but it propagates verbatim into every translation edition, since action-translation copies _toc.yml from source as-is. It surfaced as a review comment on the downstream PR, where fixing it locally would only have created drift against this repo.

Worth correcting here so it stops being re-copied.

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

打开 environment.yml 和 lectures/_toc.yml,然后将 channel 的拼写与 zh-cn 版本中已经使用的修正形式进行比较。将 default 改为 defaults,并删除 workspace 后面的尾随空格;运行 jb build 以确认配置仍能正确解析并顺利构建。

由索引模型根据 Issue 内容生成。

评估

技术栈
yaml
领域
build-system, documentation
Issue 类型
缺陷
难度
2/5
预计耗时
1-3 小时
活跃度
冷清
描述清晰度
描述清楚
新手友好度
82/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。