[BUG] Crash app when parsing a invalid p12 file

Open

#896 opened on May 22, 2021 1 comment 0 reactions 1 assignee View on GitHub

@NghiaTranUIT is already working on this.

Since May 22, 2021.

Assessment

This issue has not been assessed yet.

Description

✅ Done bug

Description

For some reason, if the user imports a custom p12 file, which is invalid, SwiftNIO-SSL might crash the app if it could not parse the p12 file properly.

It's crashed due to the fatalError()

https://github.com/apple/swift-nio-ssl/blob/9c457d021e8be61d02941dafc2f34da80f328d2e/Sources/NIOSSL/SSLPKCS12Bundle.swift#L65

We should throw the exception instead of crashing the app.

Dominant language: No language data
Stars: 7k
Forks: 237
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

[BUG] Crash app when parsing a invalid p12 file

Assessment

Description

Description

Contributor guide

First steps

More from ProxymanApp/Proxyman

Get new issues in your inbox