Ignore IME keydown events in the Rooster iframe bridge

Open Beginner friendly
#539 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript
Domain
frontend

Research direction

Start at the useBubbleIframeEvents entry point and inspect the existing iframe shortcut and bubbling bridge flow. Use the focused red/green tests mentioned in the issue; done means both IME cases return before bridge handling while the normal keydown case still passes.

Written by the indexing model from the issue text.

Description

useBubbleIframeEvents forwards keydown events from the Rooster wrapper through the iframe shortcut and bubbling bridge. IME keydown events identified by event.isComposing or event.keyCode === 229 should not enter this bridge.

These events should return before shortcut handling or cloned event dispatch. Normal keydown events should continue through the existing path.

Focused red/green tests confirm that both IME cases fail against the pre-change source while the normal keydown case passes. All three cases pass with the change.

Dominant language
TypeScript
Stars
5.6k
Forks
715
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ProtonMail/WebClients

All issues in ProtonMail/WebClients

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.