Dispose Rooster editor initialized after unmount

Open
#535 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
react, typescript
Domain
frontend

Research direction

Start at the useInitRooster hook and follow its initRoosterEditor promise together with the unmount cleanup and isMounted guard. Verify the lifecycle behavior for initialization completing after unmount: the newly created editor is disposed and onReady is not called.

Written by the indexing model from the issue text.

Description

useInitRooster awaits initRoosterEditor(). If the component unmounts before initialization finishes, cleanup runs while editorRef is still unset.

When initialization later resolves, the isMounted() guard returns without disposing the newly created editor.

The editor should be disposed when initialization finishes after unmount, and onReady should not be called.

Dominant language
TypeScript
Stars
5.6k
Forks
715
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ProtonMail/WebClients

All issues in ProtonMail/WebClients

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.