Project-MONAI / Project-MONAI/MONAILabel

Possible enhancements of `monailabel/utils/others/generic.py`

Open
#1,408 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
891
Forks
269
Avg merge
15h 41m
Merged PRs (30d)
1

Description

I viewed the code of this file, and found some places that may have issues or can be enhanced.

  1. https://github.com/Project-MONAI/MONAILabel/blob/f0d3c6b8258301aaff18606b2c5a5a376f4714d4/monailabel/utils/others/generic.py#L349:L356
    I think here can define a function for this part, and then another place can also call this function.
  2. It seems now we cannot support to download ngc bundles with specified version number (see: https://github.com/Project-MONAI/MONAILabel/blob/f0d3c6b8258301aaff18606b2c5a5a376f4714d4/monailabel/utils/others/generic.py#L356), should we also support it?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading monailabel/utils/others/generic.py around lines 308–318 and 349–356. Compare the duplicated logic and trace how NGC bundle downloads currently handle versions. Done means the shared function is used where appropriate and specified NGC bundle versions are supported, with the relevant behavior checked against existing project tests or download flows.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cloud, tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.