Project-MONAI / Project-MONAI/MONAI
refactoring the cache-based datasets
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 8.7k
- Forks
- 1.6k
- Avg merge
- 5d 1h
- Merged PRs (30d)
- 20
Description
currently all of the cache-based datasets have interfaces (or similar logic) for
-
'pre_transform'
https://github.com/Project-MONAI/MONAI/blob/c17c825324c607622967dd4331b29aefa4525b62/monai/data/dataset.py#L301-L303 -
'post_transform'
https://github.com/Project-MONAI/MONAI/blob/c17c825324c607622967dd4331b29aefa4525b62/monai/data/dataset.py#L324-L326
as it's pointed out by @atbenmurray, would be great to decouple this caching logic out of the dataset classes, as a more flexible caching mechanism + modified compose.
cc @rijobro @ericspod @Nic-Ma
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the pre_transform and post_transform logic in monai/data/dataset.py, then compare how the cache-based dataset classes expose similar interfaces. Define how caching can be decoupled from dataset classes and how a modified Compose should support the more flexible mechanism; done means the affected cache-based datasets no longer own this duplicated caching logic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100