PowerShell / PowerShell/vscode-powershell
Add creation and validation of ScriptAnalyzer settings files
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 1.9k
- Forks
- 548
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Prerequisites
- I have written a descriptive issue title.
- I have searched all issues to ensure it has not already been reported.
Summary
👋
As a module developer, I want to be able to add a ScriptAnalyzer settings file to my project easily, so it's stored alongside my code for consistency.
Something akin to dotnet new editorconfig that gives me some reasonable baseline that I can then tweak to my liking. I want to know what points of configurability are possible, and when there are issues with my settings file.
PSSA, in https://github.com/PowerShell/PSScriptAnalyzer/pull/2176, introduced 2 new cmdlets. The functionality of which could be exposed via PSES in the VSCode Extension.
-
New-ScriptAnalyzerSettingsFile- Creates a ScriptAnalyzer settings file populated with all rule names and rule configuration (set to default values). The file has some comment help for each field. The file is always namedPSScriptAnalyzerSettings.psd1so that automatic settings discovery inInvoke-ScriptAnalyzerpicks it up without any-Settingsparameter needed. Example outputs in this gist. -
Test-ScriptAnalyzerSettingsFile- Validates key elements of a settings file (such as hashtable keys being valid, rule names being recognised etc) and tells you what's wrong and where. Problems are returned as aDiagnosticRecordwith a best endeavours extent.
Opening this for feedback (and to raise some awareness of the new cmdlets for feedback on those too 🙂). I would be interested in giving the implementation a go, if the project think it's a reasonable idea (or some version of it) and would be happy with a PR.
Proposed Design
I'm not sure what the correct user experience is. But something like:
-
Add a code action/UI to create a new ScriptAnalyzer settings file.
If there are multiple root folders in the workspace, the user may then need to pick which folder to add it to.
The cmdlet has a
BasedOnparameter that accepts a Preset name, so you could then show a list of presets to base it on - though I'm personally not a fan of the presets.When all optional info collected, the
New-ScriptAnalyzerSettingsFilecmdlet would be called with the directory-Pathwhere the new settings file should be created. -
When the open file/active editor is called
PSScriptAnalyzerSettings.psd1: as well asInvoke-ScriptAnalyzer, also runTest-ScriptAnalyzerSettingsFileagainst the file and surface any resultingDiagnosticRecords returned.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Überprüfe die bestehende Invoke-ScriptAnalyzer-Integration und die Code-Action/UI-Einstiegspunkte der Erweiterung und verfolge anschließend, wie ein aktiver Editor und Workspace-Ordner behandelt werden. Das Feature ist fertig, wenn Benutzer PSScriptAnalyzerSettings.psd1 erstellen können und Diagnosen von Test-ScriptAnalyzerSettingsFile erhalten, wenn diese Datei geöffnet ist.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- powershell, typescript, vscode
- Bereich
- developer-experience, tooling
- Issue-Typ
- Feature
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Ruhig
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 52/100