PowerShell / PowerShell/PowerShellEditorServices

Remote PSSession disconnects after launch debugging session ends

Aperta
#2,263 1 commento 1 reazione 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Issue-Bug Needs: Triage
Lingua principale
C#
Stelle
767
Fork
266
Merge medio
3g 16h
PR unite (30g)
1

Descrizione

Prerequisites
  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with PowerShell Editor Services itself and does not reproduce in a standalone PowerShell instance, and is not an issue with my editor.
  • I have verified that I am using the latest version of PowerShell Editor Services.
  • If this is a security issue, I have read the security issue reporting guidance.
Summary

When using remote PowerShell debugging from VS Code server (Linux → Windows over PSSession over SSH) with a launch configuration and path mappings, the remote PSSession unexpectedly drops immediately after the debug session finishes. As soon as any command is run post-debugging, the user gets kicked back to the local session.

Technical Analysis

After investigating the PowerShellEditorServices codebase, I traced the issue through this execution flow:

  1. Launch sessions never set ExecutionCompleted = true when they finish normally. Unlike Attach sessions (which set this via OnExecutionCompletedAsync in LaunchAndAttachHandler.cs:493), Launch sessions execute via ConfigurationDoneHandler.LaunchScriptAsync() which has no equivalent completion handler.

  2. When the debug session ends, DisconnectHandler checks ExecutionCompleted (DisconnectHandler.cs:55-58)

  3. Because ExecutionCompleted is still false, it calls _debugService.Abort()

  4. Abort() calls SetDebugResuming(DebuggerResumeAction.Stop) (PowerShellDebugContext.cs:97)

  5. SetDebugResuming() calls _psesHost.SetExit() (PowerShellDebugContext.cs:115)

  6. SetExit() sets _shouldExit = true on the remote frame when it's a REPL with multiple frames (PsesInternalHost.cs:360-371)

  7. The next time the run loop executes (RunExecutionLoop, around line 917), it sees _shouldExit == true for a remote, non-nested REPL frame and calls PopPowerShell() (PsesInternalHost.cs:917-922)

  8. PopPowerShell() pops the remote REPL frame and detects the runspace change, which causes it to pop from _runspaceStack, exiting the PSSession (PsesInternalHost.cs:763-790)

Root Cause

Launch sessions do not set ExecutionCompleted = true when the debugged script finishes. This causes DisconnectHandler to treat a normal completion as an abort scenario, calling Abort() which ultimately sets _shouldExit = true on the remote REPL frame, causing the PSSession to exit.

Proposed Fix

Set ExecutionCompleted = true in ConfigurationDoneHandler.LaunchScriptAsync() after script execution completes:

await _executionService.ExecutePSCommandAsync(
    command,
    CancellationToken.None,
    s_debuggerExecutionOptions).ConfigureAwait(false);

// Fix: Mark execution as completed for launch sessions
if (_debugStateService is not null)
{
    _debugStateService.ExecutionCompleted = true;
}

_debugAdapterServer?.SendNotification(EventNames.Terminated);

This aligns the behavior of Launch sessions with Attach sessions, which already set this flag in OnExecutionCompletedAsync.

PowerShell Version
$PSVersionTable        

Name                           Value
----                           -----
PSVersion                      7.5.4
PSEdition                      Core
GitCommitId                    7.5.4
OS                             Rocky Linux 8.10 (Green Obsidian)
Platform                       Unix
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
Editor Version
emacs --version

GNU Emacs 30.1.90
PowerShell Editor Services Version
$pseditor.EditorServicesVersion

Major  Minor  Build  Revision
-----  -----  -----  --------
4      4      0      0
Steps to Reproduce

Steps to Reproduce

Set up VS Code server on Linux
Configure launch debugging with path mappings
Establish remote PSSession to Windows machine over SSH
Set breakpoint
Start a launch-based debug session
Let the debug session complete normally
Run any command in the remote session
Observe that the PSSession drops and returns to local session
Expected Behavior
The remote PSSession should remain active after a launch debug session completes, allowing continued work in the remote context.

Actual Behavior
The remote PSSession drops immediately after the first command is run following debug session completion.

Visuals

No response

Logs

No response

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia da ConfigurationDoneHandler.LaunchScriptAsync e confronta la gestione del completamento con OnExecutionCompletedAsync in LaunchAndAttachHandler.cs; quindi traccia DisconnectHandler.cs e il ciclo di esecuzione di PsesInternalHost.cs descritto nel report. La modifica è completa quando una sessione di debug del launch terminata normalmente lascia attiva la PSSession remota per il comando successivo.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
csharp, powershell, vscode
Ambito
devtools
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
55/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.