PowerShell / PowerShell/PowerShellEditorServices

Write event on configurationDone for attach requests

未关闭
#2,245 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

Issue-Enhancement Needs: Triage
主要语言
C#
星标
767
派生
266
平均合并
3 天 16 小时
30 天内合并 PR
1

描述

Prerequisites
  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been requested.
Summary

On attach scenarios, it is not possible to wait for all the breakpoints set by the client to be set in the remote runspace. A client could have something like

$originalRunspaces = Get-Runspace

Read-Host -Prompt "Please attach to process $pid with runspace $([Runspce]::DefaultRunspace.Id)"

# Waits for VSCode to attach to runspace, an extra runspace will be created by
# Enter-PSHostProcess
while ($true) {
    $newRunspace = Get-Runspace | Where-Object { $_.Id -notin $runspaces.Id } | Select-Object -First 1
    if ($newRunspace) {
        break
    }
    Start-Sleep -Milliseconds 300
}

& .\script.ps1

But this only checks that PSES has attached to the named pipe. It won't wait for PSES to have called Debug-Runspace on the target runspace and more importantly any breakpoints inside script.ps1 to be set. It's also error prone if you cannot control when the attach actually happens as the additional runspace check could have occurred before the first Get-Runspace call.

What would be ideal is for a well known event to be created by PSES when configurationDone was received so that the client only had to do

# Attach to this runspace somehow

$e = Wait-Event -SourceIdentifier PSES.ConfigurationDone -Timeout 30
if ($e) {
    $e | Remove-Event
}
else {
    throw "Timed out waiting for attach event"
}
Proposed Design

My proposal requires some changes to PowerShell itself but I wanted to see if the general idea was acceptable before trying to propose the change there. The benefit of using an event is that no custom functions needed to be loaded, and subsequently checked by the code, and Wait-Event has a simple timeout operation.

Ultimately what needs to happen is for PowerShell to expose a __New-Event command, similar to the new __Set-PSBreakpoint commands, that is treated specially by the PSRemoting server. This would be able to do the following but without having to spin up a new pipeline.

$runspace = Get-Runspace -Id $runspaceId
$runspace.Events.GenerateEvent($SourceId, $Sender, $EventArgs, $EventData)

We cannot just have PSES run this script or call New-Event directly as the runspace pipeline is busy running Debug-Runspace. The only time it can run commands is if the caller ran Wait-Debugger which is not ideal as it will pause the execution and require the client to continue on manually.

An alternative that I haven't tried out yet is to delay Debug-Runspace until after configurationDone is sent. This would allow both the breakpoints and event to be manually emited as commands on the runspace specified without having to block the pipeline with Debug-Runspace. I am not sure if that will be possible though but it could be an option that doesn't require any changes to PowerShell itself.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先跟踪 PowerShell Editor Services 的 attach 流程以及对 debug adapter protocol 的 configurationDone 请求的处理,然后查看 issue 中描述的 PowerShell remoting 事件 API。当 attach 客户端能够在断点配置完成后等待一个已知的 PSES.ConfigurationDone 事件时,即表示完成;首先确定这是否需要修改 PowerShell 本身,还是只需要修改 PSES。

由索引模型根据 Issue 内容生成。

评估

技术栈
csharp, powershell
领域
devtools
Issue 类型
功能
难度
5/5
预计耗时
一周以上
活跃度
停滞
描述清晰度
需要澄清
新手友好度
25/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。