PowerShell / PowerShell/PowerShellEditorServices

Refactor EditorUIService to use LSP showMessage and showMessageRequest

Open
#2,179 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Issue-Enhancement Needs: Triage
Dominant language
C#
Stars
767
Forks
266
Avg merge
3d 16h
Merged PRs (30d)
1

Description

Prerequisites
  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.
Summary

EditorUIService currently uses custom messages to handle prompts. They should use the LSP spec for this instead so it doesn't have to be handled special in the client.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_showMessageRequest

Proposed Design

Replace existing messaging with LSP but keep methods the same if possible to avoid breaking.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating EditorUIService and reviewing how its current custom prompt messages are handled. Read the linked LSP 3.17 window/showMessageRequest specification, then identify the existing message methods and determine whether they can retain their signatures while using LSP messaging; done means prompts use the standard LSP messages without special client handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api, developer-experience
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.