PowerShell / PowerShell/PowerShellEditorServices

Verify the main runspace reset method in the PSES pipeline thread consumer

未关闭
#1,595 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

Area-Engine Area-Threading Issue-Bug
主要语言
C#
星标
767
派生
266
平均合并
3 天 16 小时
30 天内合并 PR
1

描述

We have a kind of primitive stab at a method to clean up a faulty runspace state in the PSES pipeline thread consumer here:

https://github.com/PowerShell/PowerShellEditorServices/blob/9fd0dfa58438a9ba2b2d3cdfe22cd9cad5df70b0/src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs#L784-L826

We need to induce a fault and see if this works as expected, as well as ensure it doesn't run at other times...

My suspicion is that it will need some refinement and could have some significant bugs in it. But it's currently a corner case and a worse-case scenario handler anyway (if it didn't exist, we are essentially crashed).

So we need to investigate this and see how we can improve:

  • detection of bad runspace state
  • restoration of good runspace state
  • how our threading mechanisms work in this scenario...

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

先从 src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs 的第 784–826 行附近开始,然后跟踪 pipeline 线程消费者及其 runspace 状态处理。诱发 issue 中描述的错误 runspace 条件,并验证检测、恢复,以及 reset 不会在正常运行期间执行;当行为得到确认,或所需的改进已记录并经过测试时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
csharp, powershell
领域
devtools
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。