The Parser is handing out Internal objects like candy and (may be) poisoning children

Trying to write a ScriptAnalyzer rule, and needed to generate an Extent for the DiagnosticRecord which is slightly modified from the ones found in the AST object that are passed to me ...

Imagine my surprise when I tried to cast the .Extent on one of these AST objects to a System.Management.Automation.Language.ScriptExtent and got an exception saying PowerShell doesn't know how to convert a System.Management.Automation.Language.InternalScriptExtent to that.

So then I tried to just make one:

[System.Management.Automation.Language.ScriptExtent]::new(
   $FunctionAst.Extent.StartScriptPosition, 
   $FunctionAst.Extent.EndScriptPosition)

Did you know that InternalScriptExtent.StartScriptPosition and EndScriptPosition are also internal classes? Of course! So now I get a giant wall of red which is best summarized as:
Cannot convert "InternalScriptPosition" to type "ScriptPosition"

All I wanted to do was increment the line numbers, so I had to write this:

# Because we can't just modify $comment.Extent:
# $comment.Extent.StartScriptPosition.LineNumber += $Extent.StartLineNumber -1
# We have to create a whole new ScriptExtent object:
$Extent = [System.Management.Automation.Language.ScriptExtent]::new(
            [System.Management.Automation.Language.ScriptPosition]::new(
            $FunctionAst.Extent.StartScriptPosition.File,
            ($FunctionAst.Extent.StartScriptPosition.LineNumber + $comment.Extent.StartScriptPosition.LineNumber - 1),
            $FunctionAst.Extent.StartScriptPosition.ColumnNumber,
            $comment.Extent.StartScriptPosition.Line,
            $FunctionAst.Extent.StartScriptPosition.GetFullScript()),

            [System.Management.Automation.Language.ScriptPosition]::new(
            $FunctionAst.Extent.EndScriptPosition.File,
            ($FunctionAst.Extent.EndScriptPosition.LineNumber + $comment.Extent.EndScriptPosition.LineNumber - 1),
            $FunctionAst.Extent.EndScriptPosition.ColumnNumber,
            $comment.Extent.EndScriptPosition.Line,
            $FunctionAst.Extent.EndScriptPosition.GetFullScript())
        )

But I found the output of this has the StartOffset and EndOffset always equal to zero -- and they are not settable in any way, because they're ReadOnly and not exposed to the constructors.

1. Feature request: add a cast operator to the ScriptExtents please
2. Feature request: add a cast operator to the ScriptPositions please
3. Feature request: make all of the numbers on the public objects settable
4. Bug: stop returning Internal objects from public APIs (in this case, Parser.Parse)

cc @daxian-dbw

Commencez par suivre Parser.Parse ainsi que les types publics ScriptExtent et ScriptPosition, en les comparant aux objets InternalScriptExtent et InternalScriptPosition décrits dans le rapport. Clarifiez lequel des quatre changements demandés entre dans le périmètre, puis ajoutez une couverture ciblée pour le comportement choisi de l’API publique, y compris la préservation des offsets le cas échéant.