PowerShell / PowerShell/PSScriptAnalyzer
Compiler warning in UseCompatibleCmdlets class due unfinished feature with # if DEBUG pragma -> consider removal to allow us to use the /warnaserror compiler option
未关闭
@bergmeister 已经在做这个了。
开始于 2018年2月28日。
Area - Build
Up-for-Grabs
- 主要语言
- C#
- 星标
- 2.2k
- 派生
- 414
- 平均合并
- 13 小时 1 分钟
- 30 天内合并 PR
- 2
描述
UseCompatibleCmdlets produces a compiler warning when being compiled in Release mode:
UseCompatibleCmdlets.cs(38,27): warning CS0649: Field 'UseCompatibleCmdlets.RuleParameters.mode' is never assigned to, and will always have its default value null [C:\projects\psscriptanalyzer\Rules\Rules.csproj]
This seems to be due a 2 year old, unfinished feature that littered lots of #if DEBUG pragmas in this class. The blame does not tell me a referenced issue, therefore I would argue to remove this compile conditional code.
The benefit of this cleanup would also be that we could use the /warnaserror compiler option for a more rigorous test of code changes in CI.
What do you think @JamesWTruher ?
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。