PowerShell / PowerShell/PSScriptAnalyzer
Rule Request: UnknownLabel
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.2k
- Forks
- 414
- Avg merge
- 13h 1m
- Merged PRs (30d)
- 2
Description
Not sure whether this is a PowerShell a bug or feature but fixing it in PowerShell would probably be a break change.
In any case, I think unknown labels should be notified and even deserve an error severity if the label doesn't exist or is outside the concerned loop.
Invoke-ScriptAnalyzer -ScriptDefinition {
:foo foreach ($a in 1,2,3) {
$a
if ($a -ge $b) { break bar }
}
}.ToString()
Expected
Something like:
RuleName Severity ScriptName Line Message
-------- -------- ---------- ---- -------
PSUnknownLabel Error 4 The label 'bar' is not known in this context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Invoke-ScriptAnalyzer example and inspect how existing rules report control-flow issues. Determine where unknown labels and labels outside the concerned loop are analyzed, then verify that the completed rule reports PSUnknownLabel with Error severity and the expected message for the sample.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, powershell
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100