PowerShell / PowerShell/PSScriptAnalyzer
Format document converting timestamp within single quotes
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 2.2k
- Forks
- 414
- Avg merge
- 13h 1m
- Merged PRs (30d)
- 2
Description
From @sk82jack on December 14, 2018 0:20
System Details
System Details Output
### VSCode version: 1.30.0 c6e592b2b5770e40a98cb9c2715a8ef89aec3d74 x64
### VSCode extensions:
CoenraadS.bracket-pair-colorizer@1.0.61
eamodio.gitlens@9.2.0
ms-azure-devops.azure-pipelines@1.145.1
ms-python.python@2018.12.0
ms-vscode.csharp@1.17.1
ms-vscode.PowerShell@1.10.1
ms-vsliveshare.vsliveshare@0.3.1013
### PSES version: 1.10.1.0
### PowerShell version:
Name Value
---- -----
PSVersion 5.1.17763.134
PSEdition Desktop
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
BuildVersion 10.0.17763.134
CLRVersion 4.0.30319.42000
WSManStackVersion 3.0
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
Issue Description
When running format document on a script it is converting an ISO 8601 timestamp within a string to a more human-readable string.
The issue has been reproduced by someone in the PowerShell slack and if you want to try and reproduce it yourself then feel free. Script here https://github.com/sk82jack/PSFPL/blob/master/Tests/Private/ConvertTo-FplObject.Tests.ps1#L48
I am trying to copy the timestamp string from line 67 into line 48
Expected Behaviour
I'd expect text in quotes to not be altered.
Actual Behaviour
Probably best described by a gif:

Once it converts it it then starts being weird and reporting errors that weren't reported before:

So, if I Ctrl+Z and then format again and then it doesn't convert it but it does remove the single quote from the end of line 48. I think that must be related to the previously reported errors but it still reports errors after removing the quote:

So, I Ctrl+Z again and try and format again but the integrated console usually crashes at this point.
Attached Logs
Copied from original issue: PowerShell/vscode-powershell#1657
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproduction in Tests/Private/ConvertTo-FplObject.Tests.ps1, especially lines 48 and 67, and reproduce the behavior through the format document command. Trace how the formatter handles the single-quoted ISO 8601 timestamp and verify that quoted text remains unchanged without introducing parse errors or console crashes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- powershell
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100