Exception tabbing through git branches

Open
#4,187 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, powershell
Domain
cli

Research direction

Start with the exception path through Menu.UpdateMenuSelection, MenuCompleteImpl, and PossibleCompletionsImpl. Reproduce on Windows Terminal with PowerShell 7.4.5 by tabbing through available git branches, then trace the menu selection and console buffer dimensions. Done means branch completion no longer raises the reported ArgumentOutOfRangeException.

Written by the indexing model from the issue text.

Description

Needs-Triage :mag:
Prerequisites
  • Write a descriptive title.
  • Make sure you are able to repro it on the latest released version
  • Search the existing issues, especially the pinned issues.
Exception report
### Environment
PSReadLine: 2.3.5+2cc85806c561a9395751a96a818e8ff1592d19f7
PowerShell: 7.4.5
OS: Microsoft Windows 10.0.22631
BufferWidth: 112
BufferHeight: 27

Last 200 Keys:

 " U p d a t e Spacebar d i Tab RightArrow Enter
 g i t Spacebar p u s h Enter
 g i t Spacebar c h Tab Spacebar m Tab RightArrow Enter
 c d Spacebar . . Enter
 c d Spacebar r e Tab Tab Tab Enter
 g i t Spacebar p u l l Enter
 g h Spacebar p r Spacebar l i s t Enter
 g h Spacebar p r Spacebar c h e c k o u t Spacebar 5 9 6 Enter
 n p m Spacebar i n RightArrow Enter
 n p m Spacebar r u n Spacebar a l l Enter
 g i t Spacebar a d d Spacebar * Enter
 g i t Spacebar c o Tab Spacebar - m Spacebar RightArrow Enter
 g i Spacebar t p u s h Backspace Backspace Backspace Backspace Backspace Backspace t Spacebar p u s h Enter
 g i t Spacebar c h Tab Spacebar m RightArrow Enter
 g i t Spacebar b r Tab Spacebar - v Enter
 g i t Spacebar b r a n d h Spacebar - Backspace Backspace Backspace Backspace c h Spacebar - d Spacebar d Tab Ctrl+Spacebar Tab

### Exception

System.ArgumentOutOfRangeException: The value must be greater than or equal to zero and less than the console's buffer size in that dimension. (Parameter 'top')
Actual value was 27.
   at System.ConsolePal.SetCursorPosition(Int32 left, Int32 top)
   at Microsoft.PowerShell.PSConsoleReadLine.Menu.UpdateMenuSelection(Int32 selectedItem, Boolean select, Boolean showTooltips, String toolTipColor)
   at Microsoft.PowerShell.PSConsoleReadLine.MenuCompleteImpl(Menu menu, CommandCompletion completions)
   at Microsoft.PowerShell.PSConsoleReadLine.PossibleCompletionsImpl(CommandCompletion completions, Boolean menuSelect)
   at Microsoft.PowerShell.PSConsoleReadLine.CompleteImpl(Boolean menuSelect)
   at Microsoft.PowerShell.PSConsoleReadLine.MenuComplete(Nullable`1 key, Object arg)
   at Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
   at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken, Nullable`1 lastRunStatus)
Screenshot

image

Environment data
PS Version: 7.4.5
PS HostName: ConsoleHost (Windows Terminal)
PSReadLine Version: 2.3.5
PSReadLine EditMode: Windows
OS: 10.0.22621.1 (WinBuild.160101.0800)
BufferWidth: 112
BufferHeight: 27
Steps to reproduce

Was tabbing through available git branches

Expected behavior

no exception

Actual behavior

error

Dominant language
C#
Stars
4.4k
Forks
341
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/PSReadLine

All issues in PowerShell/PSReadLine

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.