Exception tabbing through git branches
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start with the exception path through Menu.UpdateMenuSelection, MenuCompleteImpl, and PossibleCompletionsImpl. Reproduce on Windows Terminal with PowerShell 7.4.5 by tabbing through available git branches, then trace the menu selection and console buffer dimensions. Done means branch completion no longer raises the reported ArgumentOutOfRangeException.
Written by the indexing model from the issue text.
Description
Prerequisites
- Write a descriptive title.
- Make sure you are able to repro it on the latest released version
- Search the existing issues, especially the pinned issues.
Exception report
### Environment
PSReadLine: 2.3.5+2cc85806c561a9395751a96a818e8ff1592d19f7
PowerShell: 7.4.5
OS: Microsoft Windows 10.0.22631
BufferWidth: 112
BufferHeight: 27
Last 200 Keys:
" U p d a t e Spacebar d i Tab RightArrow Enter
g i t Spacebar p u s h Enter
g i t Spacebar c h Tab Spacebar m Tab RightArrow Enter
c d Spacebar . . Enter
c d Spacebar r e Tab Tab Tab Enter
g i t Spacebar p u l l Enter
g h Spacebar p r Spacebar l i s t Enter
g h Spacebar p r Spacebar c h e c k o u t Spacebar 5 9 6 Enter
n p m Spacebar i n RightArrow Enter
n p m Spacebar r u n Spacebar a l l Enter
g i t Spacebar a d d Spacebar * Enter
g i t Spacebar c o Tab Spacebar - m Spacebar RightArrow Enter
g i Spacebar t p u s h Backspace Backspace Backspace Backspace Backspace Backspace t Spacebar p u s h Enter
g i t Spacebar c h Tab Spacebar m RightArrow Enter
g i t Spacebar b r Tab Spacebar - v Enter
g i t Spacebar b r a n d h Spacebar - Backspace Backspace Backspace Backspace c h Spacebar - d Spacebar d Tab Ctrl+Spacebar Tab
### Exception
System.ArgumentOutOfRangeException: The value must be greater than or equal to zero and less than the console's buffer size in that dimension. (Parameter 'top')
Actual value was 27.
at System.ConsolePal.SetCursorPosition(Int32 left, Int32 top)
at Microsoft.PowerShell.PSConsoleReadLine.Menu.UpdateMenuSelection(Int32 selectedItem, Boolean select, Boolean showTooltips, String toolTipColor)
at Microsoft.PowerShell.PSConsoleReadLine.MenuCompleteImpl(Menu menu, CommandCompletion completions)
at Microsoft.PowerShell.PSConsoleReadLine.PossibleCompletionsImpl(CommandCompletion completions, Boolean menuSelect)
at Microsoft.PowerShell.PSConsoleReadLine.CompleteImpl(Boolean menuSelect)
at Microsoft.PowerShell.PSConsoleReadLine.MenuComplete(Nullable`1 key, Object arg)
at Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken, Nullable`1 lastRunStatus)
Screenshot
Environment data
PS Version: 7.4.5
PS HostName: ConsoleHost (Windows Terminal)
PSReadLine Version: 2.3.5
PSReadLine EditMode: Windows
OS: 10.0.22621.1 (WinBuild.160101.0800)
BufferWidth: 112
BufferHeight: 27
Steps to reproduce
Was tabbing through available git branches
Expected behavior
no exception
Actual behavior
error
- Dominant language
- C#
- Stars
- 4.4k
- Forks
- 341
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PowerShell/PSReadLine
-
Needs-Triage :mag:
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
PowerShell/PSReadLine#5205 ·
-
Needs-Triage :mag:
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PowerShell/PSReadLine#5195 ·
-
Needs-Triage :mag:
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
PowerShell/PSReadLine#5121 ·
-
Needs-Triage :mag:
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
PowerShell/PSReadLine#5045 ·
-
Area-CommandHelp Issue-Enhancement
Difficulty 1/5 Under an hour Newbie friendliness 68/100
PowerShell/PSReadLine#3470 · 3 reactions ·
All issues in PowerShell/PSReadLine
Similar issues
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 75/100
sillsdev/languageforge-lexbox#2665 ·
-
bug documentation frontend
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
azurenoops/spin_agent#975 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
:watch: Not Triaged 11.0 fundamentals/subsvc
Difficulty 2/5 1-3 hours Newbie friendliness 92/100
dotnet/AspNetCore.Docs#37699 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
SubtitleEdit/subtitleedit#15108 · 1 comment ·