Remove "L2tpPsk" from the history

Open
#4,077 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
55/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
csharp, powershell
Domain
cli, security

Research direction

Open History.cs at the referenced list near line 117 and review how sensitive command parameters are filtered from history. Add L2tpPsk to that list, then verify that Add-VpnConnection and Set-VpnConnection commands using a clear-text -L2tpPsk value are excluded from history.

Written by the indexing model from the issue text.

Description

Issue-Enhancement Needs-Triage :mag:
Prerequisites
  • Write a descriptive title.
Description of the new feature/enhancement

Cmdlets Add-VpnConnection, Set-VpnConnection have a parameter -L2tpPsk that contains a secret key shared between the server and the client. I suppose this is a sensitive information and its worth to filter out commands that have this parameter with a clear-text value.

Proposed technical implementation details (optional)

Add "L2tpPsk" into the list https://github.com/PowerShell/PSReadLine/blob/master/PSReadLine/History.cs#L117

Dominant language
C#
Stars
4.4k
Forks
341
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/PSReadLine

All issues in PowerShell/PSReadLine

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.