Limit history to successful commands

Open
#4,065 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp, powershell
Domain
cli

Research direction

Start by tracing how PSReadLine commits commands to history and how the predictor consumes that history. Determine how to exclude failed commands while preserving the original $? value, then verify that failed commands no longer affect history or predictor suggestions.

Written by the indexing model from the issue text.

Description

Issue-Enhancement Needs-Triage :mag:
Prerequisites
  • Write a descriptive title.
Description of the new feature/enhancement

Can PSReadLine ignore commands that failed? It's mostly noise and bad suggestions for the predictor.

The predictor has been bullying me with a typo (build.ps1 instead of .\build.ps1) for a few weeks now until I manually edited my history file. 😆

Proposed technical implementation details (optional)

Check $? before committing to history? Will need to reset $? to original value after checking, similar to VSCode shell integration (possible conflict?)

Dominant language
C#
Stars
4.4k
Forks
341
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/PSReadLine

All issues in PowerShell/PSReadLine

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.