Set `DefaultTokenColor` to `39m` instead of `37m`

Open
#3,702 1 comment 2 reactions 1 assignee View on GitHub

@StevenBucher98 is already working on this.

Since Jun 5, 2023.

Assessment

This issue has not been assessed yet.

Description

Issue-Enhancement
Prerequisites
  • Write a descriptive title.
Description of the new feature/enhancement

Currently, the DefaultTokenColor is 37m which is white. However, when used with a light theme, that text is invisible. It would be better to use 39m which sets it to the terminals default color which would automatically adjust for light and dark themes. We should validate that popular terminals handle 39m as we expect before making the change (try light and dark themes).

Proposed technical implementation details (optional)

No response

Dominant language
C#
Stars
4.4k
Forks
341
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/PSReadLine

All issues in PowerShell/PSReadLine

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.