Remove cmdlet/cmd that error from history to reduce confusion

Open
#3,517 1 comment 10 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
cli

Research direction

The issue does not identify files, tests, or entry points. First determine how PSReadLine history predictions receive command results and how the experimental feedback provider exposes errors; then verify that removing a failed command affects prediction history but not session history.

Written by the indexing model from the issue text.

Description

Area-HistoryImprovements Area-Predictors Issue-Enhancement
Prerequisites
  • Write a descriptive title.
Description of the new feature/enhancement

When there is a cmdlet or command that errors, we should utilize the experimental feedback provider (or other method) to recognize that it was in fact an error and then remove the last line from the history PSReadLine uses for history predictions. This way historical predictions can only suggest commands that were successful. This should not remove it from the session history, only the PSReadLine history

Some questions:

  • Are erroring commands distracting for the user to have in history predictions?
  • Is it confusing for a failed command to not show up in history for users?
Proposed technical implementation details (optional)

No response

Dominant language
C#
Stars
4.4k
Forks
341
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/PSReadLine

All issues in PowerShell/PSReadLine

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.