Consider merging MoveToEndOfLine and EndOfLine methods.

Open
#2,048 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
csharp
Domain
cli

Research direction

Locate the two implementations of MoveToEndOfLine and EndOfLine referenced in the issue, then compare their behavior and call sites. Consolidate the duplicated implementations without changing command behavior, and verify the existing relevant tests or command behavior still pass.

Written by the indexing model from the issue text.

Description

Issue-Enhancement Issue-Triaged

Description of the new feature/enhancement

While authoring #2047 I noticed that two different implementations of MoveToEndOfLine and EndOfLine exist.
Consider merging those two implementations.

Dominant language
C#
Stars
4.4k
Forks
341
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/PSReadLine

All issues in PowerShell/PSReadLine

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.