Investigate perf gain by using the .NET char comparison pattern

Open
#1,915 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
csharp
Domain
cli, performance

Research direction

Start by reading the discussion in PR 1909 and the referenced UnicodeUtility.cs char-comparison pattern. Locate the corresponding character comparisons in PSReadLine, then benchmark the existing and candidate approaches. Done means recording whether the pattern provides a measurable performance gain and updating the issue with the result.

Written by the indexing model from the issue text.

Description

Issue-Enhancement Not-Planned

Description of the new feature/enhancement

This is a follow-up issue tracking the discussion in https://github.com/PowerShell/PSReadLine/pull/1909#discussion_r514055254.
We can investigate to see if we can get some perf gain by using the .NET char comparison pattern, such as in https://source.dot.net/#System.Private.CoreLib/UnicodeUtility.cs,141

Dominant language
C#
Stars
4.4k
Forks
341
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/PSReadLine

All issues in PowerShell/PSReadLine

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.