foreach not scoped correctly after curly brace

Open
#199 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
powershell
Domain
tooling

Research direction

The issue names no repository file or test. Start by reproducing the PowerShell sample and inspecting the syntax scope assigned to where{...}.foreach{...}; compare it with the parenthesized form and the where method. Done means foreach receives a specific, consistent scope after a curly brace without regressing the existing highlighting.

Written by the indexing model from the issue text.

Description

From @scriptingstudio in https://github.com/microsoft/vscode/issues/97404

Environment
  • Editor and Version (VS Code, Atom, Sublime):
    VS Code
    Version: 1.46.0-insider (user setup) also happens on 1.45
    Commit: 288852d8c26d797974bfb8aed06e1bff9b809223
    Date: 2020-05-12T05:43:31.363Z
    Electron: 7.2.4
    Chrome: 78.0.3904.130
    Node.js: 12.8.1
    V8: 7.8.279.23-electron.0
    OS: Windows_NT x64 10.0.19041
  • Your primary theme: N/A
Issue Description

Powershell methods foreach and where are not highlighted after curly bracket. With parenthesis it works fine.

Example code:

@($group).where{$_.count -gt 1 -and $_.name}.foreach{...}

"where" is highlighted.
"foreach" is not highlighted and has a very general scope

Screenshots

image

Expected Behavior

The foreach should have a more specific scope.

Code Samples
@($group).where{$_.count -gt 1 -and $_.name}.foreach{...}
Dominant language
PowerShell
Stars
151
Forks
55
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/EditorSyntax

All issues in PowerShell/EditorSyntax

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.