operator NOT (!) duplicated in unary and logical operators scopes, unary takes precedence

Open
#142 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
powershell
Domain
tooling

Research direction

Locate the syntax-highlighting grammar that defines the unary and logical operator scopes, then inspect the regex for the reported trailing |!. Verify the ! operator is classified in the intended scope and confirm the highlighting behavior in a PowerShell editor.

Written by the indexing model from the issue text.

Description

Environment
  • Editor and Version: VS Code: 1.26.1
  • Your primary theme: Monokai Dimmed
Issue Description

The NOT logical operator ! is duplicated in the unary operator (-split/-join) and in the logical operator scope, and the unary operator scope seems to take precedence.

I think this is just an accident of a |! left at the end of the unary scope's regex.

Isn't unary operators those like ++ and --? Okay, I suppose ! and -NOT operators are consider unary, but that's not where PowerShell Docs classified them.

Dominant language
PowerShell
Stars
151
Forks
55
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/EditorSyntax

All issues in PowerShell/EditorSyntax

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.