Chained methods and properties on expressions

Open
#107 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
powershell
Domain
tooling

Research direction

Start by reproducing the highlighting with the supplied PowerShell samples in Sublime and compare the regions assigned to Split(), Trim(), and the two .bar expressions. Trace the syntax rules handling chained methods and parenthesized expressions; done means each corresponding method or property receives the same region type.

Written by the indexing model from the issue text.

Description

bug scope-change

Moving from https://github.com/SublimeText/PowerShell/issues/68
And https://github.com/SublimeText/PowerShell/issues/77

Environment
  • Editor and Version (VS Code, Atom, Sublime): Sublime
  • Your primary theme: Default
Issue Description

There is inconsistency in the chained methods:

$users.Split(",").Trim()

Split and Trim get 2 different regions.

Same applies for

$foo.bar

vs

($foo).bar
Screenshots

image

Expected Behavior
  • Trim() and Split() should be the same region type
  • .bar in first and second case should be the same region type
Code Samples
$users.Split(",").Trim()

$foo.bar
($foo).bar
Dominant language
PowerShell
Stars
151
Forks
55
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PowerShell/EditorSyntax

All issues in PowerShell/EditorSyntax

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.