PointCloudLibrary / PointCloudLibrary/pcl

[PCL] lazy accessors (like PCA::getEigenVectors/getEigenValues/getCoefficients) are broken for const

Open
#782 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind: todo
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

many class templates in pcl use the lazy evaluation pattern this is a good thing except that it requires a bit more work to handle const correctness.

accessors to lazily computed values should be const. This then requires that compute_done_ be marked as mutable.

This is important in const correct client code will barf when attempting to use pcl code in a const correct way.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating PCL class templates that use lazy evaluation, especially PCA::getEigenVectors, PCA::getEigenValues, and PCA::getCoefficients. Review how their cached computation state is handled, then verify that const client code can call the lazy accessors without const-correctness errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.