PointCloudLibrary / PointCloudLibrary/pcl
openni_wrapper::DeviceXtionPro::getCurrentImage returns null pointer?
Open
Nobody has claimed this yet.
effort: trivial
good first issue
kind: todo
module: io
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Not sure if this is necessarily wrong, but why do we have
boost::shared_ptr<openni_wrapper::Image>
openni_wrapper::DeviceXtionPro::getCurrentImage (boost::shared_ptr<xn::ImageMetaData>) const throw ()
{
return (boost::shared_ptr<Image> (reinterpret_cast<Image*> (0)));
}
when for the other devices we return an actual image:
boost::shared_ptr<openni_wrapper::Image>
openni_wrapper::DevicePrimesense::getCurrentImage (boost::shared_ptr<xn::ImageMetaData> image_data) const throw ()
{
return (boost::shared_ptr<openni_wrapper::Image> (new ImageYUV422 (image_data)));
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate openni_wrapper::DeviceXtionPro::getCurrentImage and compare its behavior with openni_wrapper::DevicePrimesense::getCurrentImage. Read the surrounding device and image-wrapper code first to determine whether the null pointer is intentional or violates the interface contract; done means establishing the expected behavior and addressing or documenting the discrepancy.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100