PointCloudLibrary / PointCloudLibrary/pcl
[filters] Potentially undefined behavior in VoxelGridCovariance
Open
Nobody has claimed this yet.
kind: bug
module: filters
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Undefined behavior if floating-point expression doesn't fit into an int.
https://github.com/PointCloudLibrary/pcl/blob/0932486c52a2cf4f0821e25d5ea2d5767fff8381/filters/include/pcl/filters/impl/voxel_grid_covariance.hpp#L91
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with filters/include/pcl/filters/impl/voxel_grid_covariance.hpp at the linked line 91 and inspect the floating-point expression being converted to int. Determine the expected behavior when the value is outside the int range, then verify that the undefined behavior is removed and the affected filter behavior remains correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100