PointCloudLibrary / PointCloudLibrary/pcl
Remove or revise OpenCV integration
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
During some experiments, I found that some components require OpenCV. As this is currently not integrated within the CI I created #5519. During further local research I found the usage of HAVE_OPENCV within 26 source files - but the constant is never defined in pcl_config.h.in. Adding #cmakedefine HAVE_OPENCV 1 didn't help either. All HAVE_ defines seems to be defined by calling PCL_ADD_GRABBER_DEPENDENCY, but there is nothing for OpenCV.
I didn't found out if OpenCV support should be removed or not, so the integration should be fixed or removed (at best before release of 1.13.0)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with #5519 and inspect pcl_config.h.in, the 26 source files using HAVE_OPENCV, and the PCL_ADD_GRABBER_DEPENDENCY integration path. Determine whether OpenCV support is intended to remain, then verify the chosen fix or removal through the CI integration before the release target mentioned in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp, opencv
- Domain
- build-system, ci-cd, computer-vision
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100