PointCloudLibrary / PointCloudLibrary/pcl

Windows all-in-one installer only does a partial install when used in silent mode.

Open
#5,216 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good first issue needs: author reply platform: windows
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

Describe the bug

Windows all-in-one installer only does a partial install when used in silent mode.

Context

I am running allinoneinstaller.exe /S /D=C:/where/I/want/pcl in a CI/CD (GitHub actions, but should not matter).

Expected behavior

I expect everything to be installed, including third-party packages, cmake files, etc. Just as would happen if I run the allinone installer interactively.

Current Behavior

Only bin, lib and include are installed.

To Reproduce

Download the all-in-one installer and run with the command line above. May need to be done in an Administrator cmd/pwsh/bash.

Additional context

Maybe there are command-line switches I should pass to the NSIS installer, to make it select all options? But if there are it seems they are not documented anywhere. I found the /S and /D options on the nullsoft website, but if there are pcl-specific options needed for a full install I have not been able to find them.

I have also tried using the vcpkg installer to install libpcl into the CI/CD, but that fails with one of the dependencies (I think boost), in addition to taking literally hours of runtime.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the all-in-one installer entry point and its NSIS configuration, then reproduce the issue with allinoneinstaller.exe /S /D=C:/where/I/want/pcl. Compare silent-mode contents with an interactive install; the fix is complete when third-party packages and CMake files are installed as well as bin, lib, and include.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, github-actions
Domain
build-system, devops, release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.