PointCloudLibrary / PointCloudLibrary/pcl
[segmentation] GroundPlaneComparator depth_dependent_ has no effect
Open
Nobody has claimed this yet.
kind: bug
status: triage
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Just saw this as Clang warns: variable 'threshold' set but not used within the method compare. It seems depth_dependent_ is always true, but could be modified via the optional parameter in setDistanceThreshold. So not sure if should just remove the code or do something more with this variable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate GroundPlaneComparator::compare and setDistanceThreshold, then trace how threshold and depth_dependent_ are intended to interact. Confirm the intended behavior for the optional parameter and ensure the unused-variable warning is resolved without changing valid segmentation behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100