PointCloudLibrary / PointCloudLibrary/pcl
[tutorials] Compile issue related to random number generation
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Tried to compile the tutorials via the .ci/scripts/build_tutorials.sh with Clang 13 (default Clang on Ubuntu 21.10)
error: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 [-Werror,-Wimplicit-const-int-float-conversion]
n_cloud_b[i].normal[2] = 1024 * rand () / (RAND_MAX + 1.0f);
^~~~~~~~ ~
/usr/include/stdlib.h:86:18: note: expanded from macro 'RAND_MAX'
#define RAND_MAX 2147483647
^~~~~~~~~~
Result of building all tutorials:
Tutorial build summary
----------------------
alignment_prerejective πΈ
bare_earth πΈ
bspline_fitting πΈ
cloud_viewer πΈ
cluster_extraction πΈ
concatenate_clouds π build error
concatenate_fields π build error
concatenate_points π build error
concave_hull_2d πΈ
conditional_euclidean_clustering π build error
conditional_removal π build error
convex_hull_2d πΈ
correspondence_grouping πΈ
cylinder_segmentation πΈ
davidsdk π cmake error
don_segmentation π build error
ensenso_cameras π cmake error
extract_indices πΈ
function_filter πΈ
global_hypothesis_verification πΈ
gpu π cmake error
greedy_projection πΈ
ground_based_rgbd_people_detection πΈ
iccv2011 πΈ
implicit_shape_model πΈ
interactive_icp πΈ
iros2011 π build error
iterative_closest_point π build error
kdtree_search π build error
matrix_transform πΈ
min_cut_segmentation πΈ
model_outlier_removal π build error
moment_of_inertia πΈ
narf_descriptor_visualization πΈ
narf_feature_extraction πΈ
narf_keypoint_extraction πΈ
normal_distributions_transform πΈ
normal_estimation_using_integral_images πΈ
octree_change_detection π build error
octree_search π build error
openni_grabber πΈ
openni_narf_keypoint_extraction πΈ
openni_range_image_visualization πΈ
pairwise_incremental_registration πΈ
passthrough π build error
pcd_read πΈ
pcd_write π build error
pcl_painter2D πΈ
pcl_plotter πΈ
pcl_visualizer πΈ
planar_segmentation π build error
point_cloud_compression πΈ
project_inliers π build error
qt_colorize_cloud π build error
qt_visualizer π build error
radius_outlier_removal π build error
random_sample_consensus πΈ
range_image_border_extraction πΈ
range_image_creation πΈ
range_image_visualization πΈ
region_growing_rgb_segmentation πΈ
region_growing_segmentation πΈ
registration_api πΈ
remove_outliers π build error
resampling π build error
rops_feature πΈ
statistical_removal πΈ
stick_segmentation πΈ
supervoxel_clustering πΈ
template_alignment πΈ
tracking πΈ
vfh_recognition πΈ
voxel_grid πΈ
Succeeded building 49 out of 73 tutorials
Excluded or skipped 0 tutorials
As far as I remember: Should the tutorials are be build on the CI? On Azure I don't see it, even tutorials.yaml still exists.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up β it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running .ci/scripts/build_tutorials.sh with Clang 13 and inspect the tutorial source containing the reported RAND_MAX conversion. Then read tutorials.yaml to determine whether tutorial builds are configured for Azure CI. Done means the reported compilation issue and the CI coverage question are resolved, with the tutorial build summary checked.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, ci-cd
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100