PointCloudLibrary / PointCloudLibrary/pcl

the localmaximum filter bug

Open
#4,999 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind: bug module: filters
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

the localmaxmum fliter has an error in flitered point indces, the Points in the neighborhood of a previously identified local max can not be added to indces. the code can be modified as follow:

if (point_is_visited[iii] && !point_is_max[iii])
    {
        if (negative_)
        {
            if (extract_removed_indices_)
            {
                (*removed_indices_)[rii++] = iii;
            }
            continue;
        }
      indices[oii++] = iii;
      continue;
}

the code which check to see if a neighbor is higher than the query point assume the radius_indices is sorted, the searcher_ should be set sorted, the code can be modified as follow:

  searcher_->setInputCloud (cloud_projected);
  searcher_->setSortedResults(true);

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named; locate the localmaximum filter implementation and inspect the handling of point_is_visited, point_is_max, and the searcher_ configuration. Check how filtered point indices are produced, then verify that neighborhood points are handled correctly and that sorted search results are enabled as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.