PointCloudLibrary / PointCloudLibrary/pcl
Merge FindSSE and FindAVX cmake files
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
A cleaner solution might be to unify pcl_find_sse.cmake and pcl_find_avx.cmake, and have a single variable (e.g. ARCH_FLAGS) that contains sse, avx, and march flags, instead of SSE_FLAGS and AVX_FLAGS. But I would say the current state of this PR still works, and in the interest of getting this merged soon I would propose to not do any major changes here.
I think the cmake options PCL_ENABLE_SSE, PCL_ENABLE_AVX, and PCL_ENABLE_MARCHNATIVE give good control over which flags are added.
Originally posted by @mvieth in https://github.com/PointCloudLibrary/pcl/pull/4698#discussion_r678982988
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing pcl_find_sse.cmake and pcl_find_avx.cmake, then trace the PCL_ENABLE_SSE, PCL_ENABLE_AVX, and PCL_ENABLE_MARCHNATIVE options. The refactor is done when the files share one architecture-flags variable while preserving control over SSE, AVX, and march flags.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100