PointCloudLibrary / PointCloudLibrary/pcl
[features] "Allow setting both K and radius"
Open
Nobody has claimed this yet.
kind: request
module: features
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Currently setting both K and radius is not allowed, e.g. for normal estimation. Here is the source code: line 138 in feature.hpp
PCL_ERROR ("Both radius (%f) and K (%d) defined! ", search_radius_, k_);
I am wondering what is the consideration behind this kind of design.
In my opinion, it would be very useful if setting both is allowed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading feature.hpp around line 138 and trace how search_radius_ and k_ are configured and consumed by normal estimation. Define and validate the intended behavior when both values are set, with completion shown by the existing error no longer blocking that configuration and the resulting behavior being covered or documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100