PointCloudLibrary / PointCloudLibrary/pcl
[IO] Add Velodyne VLP-32 Support in Grabber
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Is your feature request related to a problem? Please describe.
Velodyne VLP 32 Support
Context
Getting point cloud data from Velodyne VLP-32
Expected behavior
PCL Grabber should be able to get data from Velodyne VLP-32.
Current Behavior
PCL Grabber only able to get data from Velodyne HDL-64, HDL-32 and VLP-16.
Describe the solution you'd like
Implement Velodyne VLP-32. Grabber code (pull request !4519 added)
Since VLP-16 Grabber class is not subclass friendly (essential class methods are not virtual), I made quick copy from VLP 16 class with necessary renaming and adding Velodyne VLP-32 specific parameters.
Describe alternatives you've considered
Rewriting VLP Grabber to be virtual class. Then rewrite VLP-16 grabber, before implementing VLP-32 grabber. This way both class can be both cleanly implemented without ugly code duplication.
I do not have time as of now, I see the request for VLP-32 support has been hanging in limbo for at least 3 years (See #2098)
Additional context
none
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the existing HDL-64, HDL-32, and VLP-16 grabbers, then inspect the implementation referenced in pull request !4519 and the VLP-32-specific parameters. Confirm the grabber can receive Velodyne VLP-32 point-cloud data and that the relevant integration or regression coverage passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100