PointCloudLibrary / PointCloudLibrary/pcl
[Apps] Revise raw pointers in Qt applications
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
I feel like we should be using std::unique_ptr or based on the ctor, std::shared_ptr for this pointer as well as model_ (out of purview of this PR)
Originally posted by @kunaltyagi in https://github.com/PointCloudLibrary/pcl/pull/4262#discussion_r484081659
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue concerns raw pointers in Qt applications and specifically mentions model_, but names no file, test, or concrete pointer beyond the original pull request discussion. Start by locating the affected Qt application code and reviewing that discussion; done means the identified ownership choices are revised consistently and the affected applications still build and test successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100