PointCloudLibrary / PointCloudLibrary/pcl
Improve exception safety with smart pointers
Open
Nobody has claimed this yet.
kind: proposal
needs: author reply
status: stale
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Would you like to wrap any pointer data members with the class template “std::unique_ptr”?
Update candidates:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with apps/point_cloud_editor/src/denoiseParameterForm.cpp at the DenoiseParameterForm reference, then inspect ml/src/permutohedral.cpp around pcl::Permutohedral::initOLD. Review the pointer data members in these candidates and their ownership and lifetime; done means the applicable pointer members use std::unique_ptr without changing behavior or exception safety.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100