PointCloudLibrary / PointCloudLibrary/pcl
[gpu] A CUDA file is using a private header
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
Describe the bug
NPP_staging.cu is including a private header using the form #include NPP_staging.hpp which can cause issues for users
Context
Changing the #include to the form #include <pcl/gpu/people/src/cuda/nvidia/NPP_staging.hpp> does not resolve, since it's a private header.
Expected behavior
The code should be able to use the #include <pcl/gpu/people/src/cuda/nvidia/NPP_staging.hpp> form.
Current Behavior
Fails on Ubuntu 18.08 Clang build
To Reproduce
Screenshots/Code snippets
Additional context
Opened this ticket per @kunaltyagi and @SergioRAgostinho to track this issue
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting NPP_staging.cu and the private header at pcl/gpu/people/src/cuda/nvidia/NPP_staging.hpp, then reproduce the Ubuntu 18.08 Clang build failure. Trace how this header is exposed to the build and determine what change allows the angle-bracket include form to work without treating the header as private. Done means the affected build completes successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system, computer-vision
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100