PointCloudLibrary / PointCloudLibrary/pcl
[custom] Remove empty destructors and constructors
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 11.1k
- Forks
- 4.7k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 6
Description
This issue is to split PR #4249 into smaller pieces.
Per @SergioRAgostinho
With destructors I use the following policy:
if your class defines virtual methods which it defines (literally defining, not overriding), I explicitly default it. The compiler throws warnings telling if of your class has virtual methods but the destructor is not virtual.
If a class has empty / default destructors I just remove those lines of code. If the destructor is not implicitly generated you'll get a compiler error, so there's no chance you'll mess up.
For constructors: remove all default constructors unless there's a user defined (non-default) constructor.
From @kunaltyagi: https://godbolt.org/z/8f99dG
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with PR #4249 and the linked Godbolt example to understand the intended constructor and destructor policy. Identify the affected classes and remove only empty or default definitions that meet those rules; done means the relevant code compiles without introducing destructor or constructor errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-vision
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100