PointCloudLibrary / PointCloudLibrary/pcl

[cmake] Bump minimum CMake version to 3.10

Open
#4,264 10 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind: request skill: cmake status: stale
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

Context
The currently supported minimum CMake version is 3.5. With Ubuntu 16.04 coming to EOL in less than a year.
Most of the people use the PCL binary from apt, so those on 16.04 wouldn't mind (Don't quote me on this)
Now would be a good time for beginning the transition, and in the process hopefully, modernize parts of our current CMake scripts.
The new version of CMake has some nifty features that would be useful.
I have listed some relevant for PCL below:

  1. CUDA Language Support
  2. Clang Tidy Support
  3. Google Test Support

Will add more as I find.

Expected behavior

Update minimum CMake version to 3.10

Current Behavior

Minimum CMake version to 3.10

Describe the solution you'd like

Bump the version after PCL 1.11.1 release and slowly modernize the existing components, in time for the next release after that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the minimum-version declarations across the repository's CMake scripts and review how the existing components configure their builds. Update the minimum requirement to CMake 3.10 after the PCL 1.11.1 release, then verify that the affected components still configure successfully and that the modernization scope is understood.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.