PointCloudLibrary / PointCloudLibrary/pcl

Review casts in PCL

Open
#4,230 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

effort: high effort: low good first issue help wanted kind: todo
Dominant language
C++
Stars
11.1k
Forks
4.7k
Avg merge
4d 10h
Merged PRs (30d)
6

Description

Context

With the migration to index_t, PCL will soon have some unneeded casts which should be removed

Describe the solution you'd like

Each cast needs to be reviewed and removed if it's unneeded. A non-exhaustive list of such situations:

  • assigning index_t to width
  • assigning size_t to Indices

Additional context

This will require significant help from others since the scope is wide, but the issue is not hard at all. To get an idea of the scale, please check the occurrence of static_cast via:

grep '\s*static_cast' * -nrH | grep -v '<float>' | grep -v 'cast<\S*\*\s*>' | wc -l

Note: this doesn't count C style casts

(High effort for total change, low for effort needed for piece-meal contributions)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

From the repository root, run the issue's grep command to list static_cast occurrences, excluding float casts and pointer casts. Review occurrences involving index_t, width, or Indices, and consider C-style casts separately; the work is done when the relevant casts have been reviewed and unneeded ones removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-vision
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.